Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cryptography (depends on #5952) #5618

Closed
srittau opened this issue Jun 11, 2021 · 9 comments · Fixed by #9459
Closed

Remove cryptography (depends on #5952) #5618

srittau opened this issue Jun 11, 2021 · 9 comments · Fixed by #9459
Labels
stubs: removal Pending removal of third-party distributions

Comments

@srittau
Copy link
Collaborator

srittau commented Jun 11, 2021

cryptography added py.typed in release 3.4.4, released 2021-02-09.

@srittau srittau added the stubs: removal Pending removal of third-party distributions label Jun 11, 2021
@srittau srittau changed the title Remove cryptography (August 2021) Remove cryptography (not before August 2021) Jun 11, 2021
@srittau srittau changed the title Remove cryptography (not before August 2021) Remove cryptography (not before September 2021) Jun 11, 2021
@hauntsaninja
Copy link
Collaborator

One fun and different thing about types-cryptography is that other typeshed packages depend on it: paramiko, PyJWT, openssl-python.

So we will need to ensure stub packages can depend on non-typeshed-stub-packages.

@hauntsaninja
Copy link
Collaborator

Just in case, does anyone feel strongly against allowing stub packages from depending on real PEP 561 packages? cc @JukkaL

@srittau
Copy link
Collaborator Author

srittau commented Jun 17, 2021

What do you mean by "real" PEP 561 packages?

@Akuli
Copy link
Collaborator

Akuli commented Jun 17, 2021

Perhaps packages that contain .py files and a py.typed file.

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Jun 17, 2021

Yup, I started with "real packages", clarified to "PEP 561 packages", but missed editing out the "real". Basically packages that can be arbitrarily big, do complicated setup.py things, be system dependent, yada yada

@srittau
Copy link
Collaborator Author

srittau commented Jun 17, 2021

Not speaking about stubs packages in general, but I think it's reasonable if typeshed packages depend on dependencies of the corresponding upstream package. I.e. if package foo depends on cryptography, it's fine that our foo-types depends on cryptography as well, since it doesn't introduce "new" dependencies. Apart from that we should vet dependencies carefully.

@JukkaL
Copy link
Contributor

JukkaL commented Jun 18, 2021

I agree with @srittau.

I think that it would be sufficient to maintain an allowlist of vetted dependencies. I'd expect that the number of such dependencies will be fairly small, so it shouldn't be much effort to maintain.

@srittau
Copy link
Collaborator Author

srittau commented Aug 24, 2021

Blocked by #5952.

@Akuli
Copy link
Collaborator

Akuli commented Dec 5, 2021

What is the current status of this? Can we now make other packages depend on cryptography?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stubs: removal Pending removal of third-party distributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants