Add stubs for Scrapy

[xlurio]

Apparently there are no type stubs for Scrapy and I always have to write it on my own. Can we start to build one?

[AlexWaygood]

Hi! We're unlikely to add stubs for Scrapy ourselves, but we'd probably accept stubs for Scrapy if you'd like to submit a PR! There's instructions in CONTRIBUTING.md for how to go about doing that. If anything's unclear, feel free to ask :)

[xlurio]

Yeah, I just wanted to create an issue before the PR so to avoid problems.
Thank you for the answer! I'll make a pull request soon enough!

[srittau]

I'm closing this issue as per our policy about stub requests, but new stub contributions are very welcome!

[afeld]

Issue around adding type hints to Scrapy: scrapy/scrapy#4041

[AlexanderHott]

Is anyone work on this yet? If not, I think I could start.

[AlexWaygood]

Is anyone work on this yet?

Not that I know of. @xlurio?

[xlurio]

Is anyone work on this yet?

Not that I know of. @xlurio?

I am, but still at 5%.

[AlexanderHott]

@xlurio I'd love to help, should I make PRs to your forked repo?

[xlurio]

@xlurio I'd love to help, should I make PRs to your forked repo?

Yes, please!

[guyarad]

@xlurio @AlexanderHott hey guys, was it abandoned?

[xlurio]

yeah... I didn't had time anymore to work on it @guyarad

[AlexanderHott]

It was a lot more work than I expected when I look into it. You would have to type the underlying parsing libraries that use xpath and css selectors, which I didn't want to get into. I don't have a use for scrapy right now, so I'm not working on it.

If you wanted to give it a shot, you should probably start with the publicly exposed dependencies that scrapy uses as return types and parameter types. As far as I rememeber, it uses parsel https://github.com/scrapy/scrapy/blob/master/scrapy/selector/unified.py#L7