gdb-stubs fixes
#9439
Merged
gdb-stubs fixes
#9439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/bminor/binutils-gdb/blob/a4418a9c6f99fd31c51698b1f6a6f8dbc1b81b6f/gdb/python/lib/gdb/printing.py#L77 and the description of "function / old way" in the body of `register_pretty_printer`. The new union's signature is equivalent to `gdb.printing.PrettyPrinter(...).__call__`.
See https://sourceware.org/gdb/onlinedocs/gdb/Blocks-In-Python.html#Blocks-In-Python: > A gdb.Block is iterable. The iterator returns the symbols (see [Symbols In Python](https://sourceware.org/gdb/onlinedocs/gdb/Symbols-In-Python.html#Symbols-In-Python)) local to the block. Implementation of `gdb.BlockIterator` is given in https://github.com/bminor/binutils-gdb/blob/gdb-12-branch/gdb/python/py-block.c. As with many of the other classes, `BlockIterator` is actually imported from the built-in `_gdb` module (https://github.com/bminor/binutils-gdb/blob/a4418a9c6f99fd31c51698b1f6a6f8dbc1b81b6f/gdb/python/lib/gdb/__init__.py#L28).
This comment has been minimized.
This comment has been minimized.
|
@pmderodat, could you possibly take a look? :) |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Hello! The changes look conform both to GDB’s doc and to its implementation, so this looks good to me, thanks! |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a few minor fixes to the
gdbstubs.I've mainly referenced an unofficial mirror https://github.com/bminor/binutils-gdb/tree/gdb-12-branch in the commit notes, although when I checked these locally, I've used
apt's distribution ofgdb 12.1(/usr/share/gdb/python/) for Ubuntu 22.04. The official git https://www.sourceware.org/gdb/current/ is less accessible when cross-checking.Symbols available in the built-in module
_gdb(accessible when running Python throughgdb) can be double-checked by runningstubgeninsidegdb(although the function/method signatures suffers the same issues as python/mypy#14094).