Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third-party tests failed on Sat May 11 2024 #381

Closed
github-actions bot opened this issue May 11, 2024 · 5 comments
Closed

Third-party tests failed on Sat May 11 2024 #381

github-actions bot opened this issue May 11, 2024 · 5 comments

Comments

@github-actions
Copy link

Runs listed here: https://github.com/python/typing_extensions/actions/workflows/third_party.yml

@AlexWaygood
Copy link
Member

Looks like both pydantic and cattrs relied on the old behaviour where the __default__ attribute would be set to None if there was no default for the TypeVar-like

@AlexWaygood
Copy link
Member

PR to fix pydantic's tests: pydantic/pydantic#9426

@AlexWaygood
Copy link
Member

PR to fix cattrs's tests: python-attrs/cattrs#536

@AlexWaygood
Copy link
Member

The latest run shows the cattrs tests are indeed now fixed after my PR was merged: https://github.com/python/typing_extensions/actions/runs/9056390917

Just pydantic to go now...

@AlexWaygood
Copy link
Member

pydantic/pydantic#9426 was merged, and this is now resolved. I've manually triggered a run of the third-party tests just to make sure, and the pydantic tests are now green: https://github.com/python/typing_extensions/actions/runs/9084446190.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant