Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the inclusion of non-timezone information files intentional? #28

Closed
mbargull opened this issue Oct 6, 2020 · 2 comments
Closed

Is the inclusion of non-timezone information files intentional? #28

mbargull opened this issue Oct 6, 2020 · 2 comments

Comments

@mbargull
Copy link

mbargull commented Oct 6, 2020

This package includes the files

zoneinfo/leapseconds
zoneinfo/iso3166.tab
zoneinfo/zone1970.tab
zoneinfo/zone.tab
zoneinfo/tzdata.zi

. Is this intentional?
Due to lack of knowledge, I can't say if it makes sense to include them or not.
I just noticed them when comparing the list of files to what the install_data Makefile target outputs.

If their inclusion is unintentional, you could simplify your make call with the install_data target to

make \
  TOPDIR="${path_to_tzdata_package}" \
  USRSHAREDIR= \
  POSIXRULES= \
  ZFLAGS='-b slim' \
  install_data

(By setting USRSHAREDIR to an empty value and TOPDIR to the directory that will hold the zoneinfo folder, you can also avoid the post-build shutil.move you currently do.)

@pganssle
Copy link
Member

pganssle commented Oct 6, 2020

This is (mostly) not non-timezone data.

tzdata.zi is an un-compiled minified version of the entire database, and contains more information than the compiled verison. The leapseconds file is the distribution of leap second timings, and the tab files have metadata about time zones in them. This project should aim to provide what a standard installation of tzdata would give you on your system, which includes these files.

@pganssle pganssle closed this as completed Oct 6, 2020
@mbargull
Copy link
Author

mbargull commented Oct 6, 2020

Thank you for the insights and confirmation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants