Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Give characters foot step sounds #14

Closed
pushfoo opened this issue Apr 27, 2022 · 1 comment
Closed

Feature: Give characters foot step sounds #14

pushfoo opened this issue Apr 27, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pushfoo
Copy link
Member

pushfoo commented Apr 27, 2022

Many games play different foot step sounds depending on which surface a character is walking on.

For example, if the player was walking on grass, each foot step event would play a random sound from a pool of grass walking sounds. If the player moved to a stone surface, the game would play the sound of boots stepping on stone instead.

To get started on this, we could simplify the tile types into the following categories:

Sound set Example tiles in map
Grass Light grass, Dark grass
Stone Cobblestone path, Dungeon floor
Dirt Dirt path, Garden, Graveyard
Wood House interior, Bridges
Sand Beaches

We can pull sounds from Kenney's impact sounds set. It is licensed under a CC0 1.0 Universal Public Domain Dedication, which means there are no licensing restrictions at all. However, It would still be polite to cite the source.

This ticket should synchronize with the same animation speed used to fix #5. The sound files should be placed in a directory under resources.

@Cleptomania Cleptomania added enhancement New feature or request good first issue Good for newcomers labels Apr 30, 2022
@Cleptomania
Copy link
Member

Added in #21 though we could do with a more full featured system for this in the future maybe, but that should probably a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants