Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for object templates #34

Closed
Cleptomania opened this issue May 7, 2021 · 1 comment
Closed

Add support for object templates #34

Cleptomania opened this issue May 7, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@Cleptomania
Copy link
Member

Object templates are separate files which store a template that can be applied to an object which specifies itself as an instance of that template.

See: https://doc.mapeditor.org/en/stable/reference/json-map-format/#object-template

@Cleptomania Cleptomania added the enhancement New feature or request label May 7, 2021
@Cleptomania Cleptomania added this to the Version 1.5 milestone May 7, 2021
@Cleptomania
Copy link
Member Author

This has been done.

Initial implementation in fec4064

Initial tests in e2573ff

As far as test coverage goes, the coverage report is good, however due the nature of templates it can't really know all the edge cases. Would be nice to have a test which covers templates of every type of object at least, if not several of each. But ya know, time and effort and all that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant