Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workshop creation/update/delete #7

Closed
vnbang2003 opened this issue Sep 20, 2015 · 8 comments
Closed

Workshop creation/update/delete #7

vnbang2003 opened this issue Sep 20, 2015 · 8 comments
Assignees
@shankisg

Comments

@vnbang2003
Copy link
Contributor

No description provided.

@shankisg
Copy link
Contributor

shankisg commented Oct 5, 2015

@vnbang2003 I can take it up. Let me know if its fine.

One more thing CBV vs FBV, which one is preferred . I have checked login, its using FBV. Pls confirm.

@vnbang2003
Copy link
Contributor Author

CBV would be good . Login page was temp it gone change soon.
@ShankiG please assign to your self

@shankisg
Copy link
Contributor

shankisg commented Oct 5, 2015

@vnbang2003 I don't have the permission to assign.

@shankisg shankisg mentioned this issue Oct 7, 2015
Closed
@shankisg
Copy link
Contributor

shankisg commented Oct 7, 2015

@vnbang2003 . I was just checking the settings files and saw it includes rest_framework library.

So, I am creating api using django rest framework for this task. Or you want me to implement it as normally django CBV .

@vnbang2003
Copy link
Contributor Author

@ShankiG API we will do it in Phase2

@shankisg
Copy link
Contributor

shankisg commented Oct 7, 2015

Ok, thanks

@shankisg shankisg mentioned this issue Oct 10, 2015
Closed
@shankisg
Copy link
Contributor

Fixed and merged
Commit# 5732162

@shankisg
Copy link
Contributor

@vnbang2003 pls close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shankisg shankisg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vnbang2003 @shankisg