feat: add copy button for code #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for code-generator ready! Built with commit a5e0951 |
ydcjeff
commented
May 5, 2021
src/components/CodeBlock.vue
Outdated
Comment on lines
60
to
61
| setTimeout(() => (copyText.value = 'Copy'), 3000) | ||
| // alert('Code has been copied to clipboard.') |
There was a problem hiding this comment.
@vfdev-5 How do we want to show Code is being copied?
Currently, it changes "Copy" to "Copied" once clicked and revert back to "Copy" after 3 seconds. OR do you want to give an alert that code has been copied?
There was a problem hiding this comment.
Tried "alert mode" locally and it's annoying when we click "Copy" again and again.
ydcjeff
added a commit
that referenced
this pull request
May 21, 2021
* feat: add copy button for code * chore: format * refactor: use string template instead of template ref * chore: remove alert code * fix: try and catch error when copying code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #103
Add copy button for
CodeBlockto copy the codeAdditional context
What is the purpose of this pull request?