feat: add sidebar for left pane for mobile #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for code-generator ready! Built with commit a9b2741 |
vfdev-5
approved these changes
May 6, 2021
ydcjeff
changed the title
trsvchn
approved these changes
May 6, 2021
ydcjeff
added a commit
that referenced
this pull request
May 21, 2021
* feat: add sidebar for left pane on mobile * feat: add box shadow for white bg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #104
Part of #103
Add a sidebar coming from left to right for left pane on mobile. There is a hamburger button in the bottom right of the window.
Additional context
Since the navigation and left pane are in each different components, it is difficult to put menu on navigation bar.
Instead I put the menu in the bottom right place of the window. That place could be helpful for full screen smartphones and one-handed users.
The place is inspired by https://reactjs.org/docs/ when viewing on mobile.
What is the purpose of this pull request?