Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error and info message box #121

Merged
merged 2 commits into from
May 15, 2021
Merged

feat: add error and info message box #121

merged 2 commits into from
May 15, 2021

Conversation

ydcjeff
Copy link
Member

@ydcjeff ydcjeff commented May 15, 2021

Description

Part of #103

  • Show error if template has not been chosen when click download
  • Show error if there is no value for required configs when click download
  • Show info after copying code to clipboard.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

Show error if template has not been chosen when click download
Show error if there is no value for required configs when click download
Show info after copying code to clipboard.
@ydcjeff ydcjeff added the enhancement New feature or request label May 15, 2021
@ydcjeff ydcjeff added this to In progress in v0.2.0 via automation May 15, 2021
@netlify
Copy link

netlify bot commented May 15, 2021

Deploy preview for code-generator ready!

Built with commit b3f0e46

https://deploy-preview-121--code-generator.netlify.app

@ydcjeff ydcjeff changed the title feat: add error/info message box feat: add error and info message box May 15, 2021
@ydcjeff ydcjeff merged commit 4ebb35b into v1 May 15, 2021
v0.2.0 automation moved this from In progress to Done May 15, 2021
@ydcjeff ydcjeff deleted the message branch May 15, 2021 16:18
ydcjeff added a commit that referenced this pull request May 21, 2021
* feat: add error/info message box

Show error if template has not been chosen when click download
Show error if there is no value for required configs when click download
Show info after copying code to clipboard.

* chore: correct messages and add reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant