Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): port text classification template (WIP) #131

Merged
merged 8 commits into from
May 26, 2021

Conversation

trsvchn
Copy link
Member

@trsvchn trsvchn commented May 24, 2021

Description

ref #103

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

@netlify
Copy link

netlify bot commented May 24, 2021

Deploy Preview for code-generator ready!

Built with commit eaceac5

https://deploy-preview-131--code-generator.netlify.app

@ydcjeff ydcjeff changed the title [WIP] Port text classification template feat(templates): port text classification template (WIP) May 24, 2021
@ydcjeff
Copy link
Member

ydcjeff commented May 24, 2021

Changed the PR title to get changelog autogenerated.

@trsvchn
Copy link
Member Author

trsvchn commented May 24, 2021

Is this some sort of "PR naming framework/convention"?

@ydcjeff
Copy link
Member

ydcjeff commented May 24, 2021

Is this some sort of "PR naming framework/convention"?

Yes, we are following this convention and using this cli tool with angular preset.

@trsvchn
Copy link
Member Author

trsvchn commented May 24, 2021

Is this some sort of "PR naming framework/convention"?

Yes, we are following this convention and using this cli tool with angular preset.

I see, thanks for the links!

@ydcjeff ydcjeff added templates enhancement New feature or request labels May 25, 2021
@ydcjeff ydcjeff added this to In progress in v0.2.0 via automation May 25, 2021
@ydcjeff ydcjeff mentioned this pull request May 25, 2021
23 tasks
@ydcjeff ydcjeff requested a review from vfdev-5 May 25, 2021 17:06
@ydcjeff
Copy link
Member

ydcjeff commented May 25, 2021

@vfdev-5 @trsvchn please review it and add anything necessary.

@vfdev-5
Copy link
Member

vfdev-5 commented May 25, 2021

There is unrelated vis.py for text classification template.

@trsvchn
Copy link
Member Author

trsvchn commented May 25, 2021

I think I have nothing to add, thanks @ydcjeff !

@ydcjeff
Copy link
Member

ydcjeff commented May 26, 2021

There is unrelated vis.py for text classification template.

will address in another PR

@ydcjeff ydcjeff merged commit 7683ede into main May 26, 2021
v0.2.0 automation moved this from In progress to Done May 26, 2021
@ydcjeff ydcjeff deleted the text-cls-template branch May 26, 2021 02:02
ydcjeff added a commit that referenced this pull request May 26, 2021
ydcjeff added a commit that referenced this pull request May 26, 2021
* fix: #131 (comment)

* fix: swap data.py and main.py in text

* fix: empty store.code before hand to show loading stauts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request templates
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants