Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: padding-right for right-pane-tabs #139

Merged
merged 3 commits into from
May 27, 2021
Merged

fix: padding-right for right-pane-tabs #139

merged 3 commits into from
May 27, 2021

Conversation

trsvchn
Copy link
Member

@trsvchn trsvchn commented May 26, 2021

Description

Fix #

Fixes padding on the right for the tab panel.

Additional context

Screenshot from 2021-05-26 08-53-51
Screenshot from 2021-05-26 08-53-55


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

@trsvchn trsvchn added the frontend Vue app label May 26, 2021
@netlify
Copy link

netlify bot commented May 26, 2021

✔️ Deploy Preview for code-generator ready!

🔨 Explore the source changes: 1c9cbd1

🔍 Inspect the deploy log: https://app.netlify.com/sites/code-generator/deploys/60ae1e6f36e36f000708a3ed

😎 Browse the preview: https://deploy-preview-139--code-generator.netlify.app/

@trsvchn trsvchn changed the title Fix right pane layout: padding-righ for tab panel fix: padding-right for right-pane-tabs May 26, 2021
@ydcjeff
Copy link
Member

ydcjeff commented May 26, 2021

We could also do with margin-right. Then we don't need to wrap in another div

@trsvchn
Copy link
Member Author

trsvchn commented May 26, 2021

@ydcjeff could you please show how to do it? Maybe via suggestion

src/components/PaneRight.vue Outdated Show resolved Hide resolved
src/components/PaneRight.vue Outdated Show resolved Hide resolved
src/components/PaneRight.vue Outdated Show resolved Hide resolved
src/components/PaneRight.vue Outdated Show resolved Hide resolved
trsvchn and others added 2 commits May 26, 2021 13:05
Co-authored-by: Jeff Yang <32727188+ydcjeff@users.noreply.github.com>
@ydcjeff ydcjeff merged commit 3bb7d50 into main May 27, 2021
@ydcjeff ydcjeff deleted the fix-rpane-layout branch May 27, 2021 09:50
@ydcjeff ydcjeff mentioned this pull request May 28, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Vue app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants