Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default value in store, save on mount #141

Merged
merged 1 commit into from
May 28, 2021
Merged

Conversation

ydcjeff
Copy link
Member

@ydcjeff ydcjeff commented May 28, 2021

Description

  • Have default value for output_dir and log_every_iters in store
  • save the default value when mounting the component

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

@ydcjeff ydcjeff added the bug Something isn't working label May 28, 2021
@ydcjeff ydcjeff added this to In progress in v0.2.0 via automation May 28, 2021
@netlify
Copy link

netlify bot commented May 28, 2021

✔️ Deploy Preview for code-generator ready!

🔨 Explore the source changes: 26e63bc

🔍 Inspect the deploy log: https://app.netlify.com/sites/code-generator/deploys/60b0b6a5698bc90007f2d9b6

😎 Browse the preview: https://deploy-preview-141--code-generator.netlify.app/

@ydcjeff ydcjeff merged commit d799a94 into main May 28, 2021
v0.2.0 automation moved this from In progress to Done May 28, 2021
@ydcjeff ydcjeff deleted the fix/no-switch-to-loggers branch May 28, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant