fix: correct naming for loggers #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydcjeff
changed the title
|
I was thinking about this approach as well, but I it will breaks all further checks, like here #::: if (it.logger === 'clearml') { :::#Do we need to do like this now? or not? #::: if (it.logger === 'ClearML') { :::# |
|
Thanks @trsvchn , we need to convert to lower case when saving. |
|
✔️ Deploy Preview for code-generator ready! 🔨 Explore the source changes: 31501f3 🔍 Inspect the deploy log: https://app.netlify.com/sites/code-generator/deploys/60b77e79e771120008c71a8f 😎 Browse the preview: https://deploy-preview-149--code-generator.netlify.app/ |
trsvchn
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the correct naming for loggers
ref #103
Additional context
What is the purpose of this pull request?