Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open in colab #162

Merged
merged 10 commits into from
Jun 22, 2021
Merged

fix: open in colab #162

merged 10 commits into from
Jun 22, 2021

Conversation

ydcjeff
Copy link
Member

@ydcjeff ydcjeff commented Jun 17, 2021

Description

fix colab not opening
ref #103

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

@netlify
Copy link

netlify bot commented Jun 17, 2021

✔️ Deploy Preview for code-generator ready!

🔨 Explore the source changes: 8c161b0

🔍 Inspect the deploy log: https://app.netlify.com/sites/code-generator/deploys/60cc1f9326099300086db0ac

😎 Browse the preview: https://deploy-preview-162--code-generator.netlify.app/

@ydcjeff ydcjeff added this to In progress in v0.2.0 via automation Jun 17, 2021
@ydcjeff ydcjeff added the bug Something isn't working label Jun 17, 2021
@ydcjeff ydcjeff requested review from trsvchn and vfdev-5 June 17, 2021 15:14
@ydcjeff ydcjeff mentioned this pull request Jun 17, 2021
23 tasks
var reqCell // !pip install ...
var configCell // %%writefile config.yaml
var lastCell // main()
// var firstCell // README
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove these commented lines? I think we do not need them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean all of them

Copy link
Member

@trsvchn trsvchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Many thanks @ydcjeff !

v0.2.0 automation moved this from In progress to Reviewer approved Jun 17, 2021
@vfdev-5
Copy link
Member

vfdev-5 commented Jun 17, 2021

Great job, Jeff ! Maybe we could add the following to the metadata to use GPU by default

  "metadata": {
    "kernelspec": {
      "display_name": "Python 3",
      "name": "python3"
    },
    "colab": {
      "name": "pytorch-ignite-notebook.ipynb",
      "provenance": []
    },
    "accelerator": "GPU"
  },

and the first cell with

# <template name> by PyTorch-Ignite Code-Generator

Please, run the cell below to execute your code.

@trsvchn
Copy link
Member

trsvchn commented Jun 17, 2021

Great job, Jeff ! Maybe we could add the following to the metadata to use GPU by default

  "metadata": {
    "kernelspec": {
      "display_name": "Python 3",
      "name": "python3"
    },
    "colab": {
      "name": "pytorch-ignite-notebook.ipynb",
      "provenance": []
    },
    "accelerator": "GPU"
  },

and the first cell with

# <template name> by PyTorch-Ignite Code-Generator

Please, run the cell below to execute your code.

And colab will start the GPU runtime for us?

@vfdev-5
Copy link
Member

vfdev-5 commented Jun 17, 2021

Great job, Jeff ! Maybe we could add the following to the metadata to use GPU by default

  "metadata": {
    "kernelspec": {
      "display_name": "Python 3",
      "name": "python3"
    },
    "colab": {
      "name": "pytorch-ignite-notebook.ipynb",
      "provenance": []
    },
    "accelerator": "GPU"
  },

and the first cell with

# <template name> by PyTorch-Ignite Code-Generator

Please, run the cell below to execute your code.

And colab will start the GPU runtime for us?

yes

@trsvchn
Copy link
Member

trsvchn commented Jun 17, 2021

Thanks! Didn't know that!

@ydcjeff ydcjeff merged commit 1564bb9 into main Jun 22, 2021
v0.2.0 automation moved this from Reviewer approved to Done Jun 22, 2021
@ydcjeff ydcjeff deleted the func/colab branch June 22, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants