Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nav bar in 404 page #180

Closed
ydcjeff opened this issue Oct 5, 2021 · 2 comments · Fixed by #184
Closed

fix nav bar in 404 page #180

ydcjeff opened this issue Oct 5, 2021 · 2 comments · Fixed by #184
Assignees
@rwiteshbera
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Hacktoberfest
Projects
v0.3.0

Comments

@ydcjeff
Copy link
Member

ydcjeff commented Oct 5, 2021

Describe the bug

Nav bar became too large in 404 page and covered the h1 title.

Screen Shot 2021-10-05 at 10 45 05

Expected result

NavBar not covered the h1 title.

Reproduction

https://code-generator.pytorch-ignite.ai/foobar

Steps to reproduce

View the reproduction link on mobile
@ydcjeff ydcjeff added bug Something isn't working good first issue Good for newcomers hacktoberfest Hacktoberfest labels Oct 5, 2021
@ydcjeff ydcjeff added this to To do in v0.3.0 via automation Oct 5, 2021
@B1TSH3LL
Copy link

B1TSH3LL commented Oct 5, 2021

I Can Work On This Issue Please Assign It To Me :)

@ydcjeff ydcjeff changed the title Nav bar in 404 page fix nav bar in 404 page Oct 5, 2021
@B1TSH3LL B1TSH3LL removed their assignment Oct 5, 2021
@rwiteshbera
Copy link
Contributor

I can work on this issue, can you please assign me this issue? @ydcjeff

@ydcjeff ydcjeff mentioned this issue Oct 5, 2021
Merged
1 task
v0.3.0 automation moved this from To do to Done Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwiteshbera rwiteshbera

Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Hacktoberfest
Projects
v0.3.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(404): navbar not cover 404 content anymore rwiteshbera/code-generator
3 participants
@ydcjeff @rwiteshbera @B1TSH3LL