Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(handlers): add common training handlers template #26

Merged
merged 4 commits into from
Mar 26, 2021
Merged

feat(handlers): add common training handlers template #26

merged 4 commits into from
Mar 26, 2021

Conversation

ydcjeff
Copy link
Member

@ydcjeff ydcjeff commented Mar 25, 2021 •
edited

This PR

  • added common training handlers using setup_common_training_handlers
  • removed unused templates in _base
  • extract each configuration options into functions
  • argparse utils are sorted by sidebar configs

@ydcjeff ydcjeff added this to the v0.1.0 milestone Mar 25, 2021
@ydcjeff ydcjeff changed the title feat(handlers): add common training handlers template [wip] feat(handlers): add common training handlers template Mar 25, 2021
@ydcjeff ydcjeff changed the title [wip] feat(handlers): add common training handlers template feat(handlers): add common training handlers template Mar 26, 2021
@ydcjeff ydcjeff requested a review from trsvchn March 26, 2021 14:48
@ydcjeff ydcjeff merged commit 5b2cbae into master Mar 26, 2021
@ydcjeff ydcjeff deleted the feat/handlers branch March 26, 2021 17:23
@ydcjeff
Copy link
Member Author

ydcjeff commented Mar 26, 2021

Merged to add another logger template

@ydcjeff ydcjeff added this to In progress in v0.1.0 via automation Apr 7, 2021
@ydcjeff ydcjeff moved this from In progress to Done in v0.1.0 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trsvchn trsvchn Awaiting requested review from trsvchn

Assignees
No one assigned
Labels
templates
Projects
No open projects
v0.1.0
Done
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ydcjeff