Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configurations in separate config file in single template #38

Merged
merged 1 commit into from
Apr 3, 2021
Merged

feat: configurations in separate config file in single template #38

merged 1 commit into from
Apr 3, 2021

Conversation

ydcjeff
Copy link
Member

@ydcjeff ydcjeff commented Apr 3, 2021

Description: This PR

  • separated the configs in utils.py into config.py
  • renamed engines to trainers
  • merged events.py into trainers.py

@ydcjeff ydcjeff requested a review from trsvchn April 3, 2021 11:08
@ydcjeff ydcjeff added enhancement New feature or request templates labels Apr 3, 2021
@ydcjeff ydcjeff added this to the v0.1.0 milestone Apr 3, 2021
trsvchn
trsvchn approved these changes Apr 3, 2021
View reviewed changes
Copy link
Member

@trsvchn trsvchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ydcjeff ! LGTM!

@ydcjeff ydcjeff merged commit 8d1227e into master Apr 3, 2021
@ydcjeff ydcjeff deleted the config-file branch April 3, 2021 11:16
@ydcjeff ydcjeff added this to In progress in v0.1.0 via automation Apr 7, 2021
@ydcjeff ydcjeff moved this from In progress to Done in v0.1.0 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trsvchn trsvchn trsvchn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request templates
Projects
No open projects
v0.1.0
Done
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ydcjeff @trsvchn