Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): show by filename, sidebar end with ignite specifics #54

Merged
merged 1 commit into from
Apr 9, 2021
Merged

fix(app): show by filename, sidebar end with ignite specifics #54

merged 1 commit into from
Apr 9, 2021

Conversation

ydcjeff
Copy link
Member

@ydcjeff ydcjeff commented Apr 8, 2021 •
edited

"View rendered {filename}" -> "{filename}"
Sidebar sorted by

  • model
  • dataset
  • dataloader
  • optimizer
  • training option
  • distributed
  • handlers
  • loggers

@ydcjeff ydcjeff added this to In progress in v0.1.0 via automation Apr 8, 2021
@ydcjeff ydcjeff added this to the v0.1.0 milestone Apr 8, 2021
@ydcjeff ydcjeff added the frontend Vue app label Apr 8, 2021
@ydcjeff
Copy link
Member Author

ydcjeff commented Apr 8, 2021

requesting review from @pytorch-ignite/project-leaders

trsvchn
trsvchn approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@trsvchn trsvchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ydcjeff LGTM!

v0.1.0 automation moved this from In progress to Reviewer approved Apr 9, 2021
@ydcjeff ydcjeff merged commit 23c87b4 into master Apr 9, 2021
v0.1.0 automation moved this from Reviewer approved to Done Apr 9, 2021
@ydcjeff ydcjeff deleted the sidebar-sort branch April 9, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trsvchn trsvchn trsvchn approved these changes

Assignees
No one assigned
Labels
frontend Vue app
Projects
No open projects
v0.1.0
Done
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ydcjeff @trsvchn