Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(download): add an option to archive and download #6

Merged
merged 5 commits into from
Mar 11, 2021

Conversation

ydcjeff
Copy link
Member

@ydcjeff ydcjeff commented Mar 10, 2021

Fixes #2

  • Add an option to generate an archive and give download link
  • streamlit doesn't have an option to download for now, so this is a temporary hack with static file serving
  • black formatted

Testing : streamlit run app/streamlit_app.py -> Generate -> give a download link

@ydcjeff ydcjeff requested review from trsvchn and vfdev-5 and removed request for trsvchn March 10, 2021 16:18
@ydcjeff
Copy link
Member Author

ydcjeff commented Mar 10, 2021

request review from @pytorch-ignite/project-leaders

app/streamlit_app.py Outdated Show resolved Hide resolved
app/streamlit_app.py Outdated Show resolved Hide resolved
app/streamlit_app.py Outdated Show resolved Hide resolved
app/codegen.py Outdated Show resolved Hide resolved
Jeff Yang and others added 2 commits March 11, 2021 12:04
Co-authored-by: Taras Savchyn <30748114+trsvchn@users.noreply.github.com>
@ydcjeff ydcjeff merged commit 3f87b20 into master Mar 11, 2021
@ydcjeff ydcjeff deleted the archive-download branch March 11, 2021 11:31
@trsvchn trsvchn added backend Backend: code gen etc frontend Vue app enhancement New feature or request labels Mar 15, 2021
@ydcjeff ydcjeff added this to the v0.1.0 milestone Mar 15, 2021
@ydcjeff ydcjeff added this to In progress in v0.1.0 via automation Apr 7, 2021
@ydcjeff ydcjeff moved this from In progress to Done in v0.1.0 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend: code gen etc enhancement New feature or request frontend Vue app
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Make tar file for generated files and an option to download
2 participants