fix: make a seed respect to distributed settings #60
Conversation
ydcjeff
changed the title
| if rank > 0: | ||
| # Ensure that only rank 0 download the dataset | ||
| idist.barrier() |
There was a problem hiding this comment.
Sorry for delay with the review @ydcjeff . Maybe we could hide these barriers inside get_datasets. I also realized that here it should be local_rank == 0 and not rank == 0 as in case multi-node case the application wont download the data for other nodes.
There was a problem hiding this comment.
OK! Then Ignite examples need a fix too
There was a problem hiding this comment.
I see, that can be possible. Thanks for pointing out! Can you please open an issue and someone could fix it.
| if rank == 0: | ||
| if isinstance(logger_handler, WandBLogger): | ||
| # why handle differently for wandb ? | ||
| # See : https://github.com/pytorch/ignite/issues/1894 | ||
| logger_handler.finish() | ||
| elif logger_handler: | ||
| logger_handler.close() |
There was a problem hiding this comment.
Maybe, we can say that the code generator aims ignite nightly version and it will be also in the stable version ?
There was a problem hiding this comment.
We are currently testing with ignite v0.4.4, we will update that once there is a new release
fix #61