Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making Text classification template similar to Image Classification [skip ci] #92

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Making Text classification template similar to Image Classification [skip ci] #92

merged 2 commits into from
Apr 19, 2021

Conversation

trsvchn
Copy link
Member

@trsvchn trsvchn commented Apr 19, 2021

Description

Fix #91

Additional context

  • Missing global expander
  • Missing message with "Names in the parenthesis are variable names used in the generated code."

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

@trsvchn trsvchn changed the title Making Text classification template similar to Image Classification Making Text classification template similar to Image Classification [skip ci] Apr 19, 2021
@vfdev-5
Copy link
Member

vfdev-5 commented Apr 19, 2021

@trsvchn can we merge it ?

vfdev-5
vfdev-5 approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@trsvchn trsvchn merged commit 16212e2 into dev Apr 19, 2021
@trsvchn trsvchn deleted the fix-sidebar-text-cls branch April 19, 2021 21:52
vfdev-5 added a commit that referenced this pull request Apr 20, 2021
@vfdev-5 @trsvchn
Merge dev to master for v0.1.0 release (#94)
58ae4b4 
* Making Text classification template similar to Image Classification (#92)

* Fix template sidebar

* Code style

* [skip ci] updated contributing and readme (#93)

* [skip ci] updated contributing

* [skip ci] Updated readme

Co-authored-by: Taras Savchyn <30748114+trsvchn@users.noreply.github.com>
vfdev-5 added a commit that referenced this pull request Apr 20, 2021
@ydcjeff @vfdev-5 @trsvchn
feat(app): add an option to include test file (#97)
a9d774b 
* Merge dev to master for v0.1.0 release (#94)

* Making Text classification template similar to Image Classification (#92)

* Fix template sidebar

* Code style

* [skip ci] updated contributing and readme (#93)

* [skip ci] updated contributing

* [skip ci] Updated readme

Co-authored-by: Taras Savchyn <30748114+trsvchn@users.noreply.github.com>

* feat(app): add an option to include test file

* fix: test_all in generate, pytest as optional dep

Co-authored-by: vfdev <vfdev.5@gmail.com>
Co-authored-by: Taras Savchyn <30748114+trsvchn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Text classification template similar to Image Classification
2 participants
@trsvchn @vfdev-5