Rename generator to vocoder in HiFiGAN model and factory functions #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
carolineechen
approved these changes
Jan 4, 2023
nateanl
force-pushed
the
rename_hifigan
branch
from
42e3ab4
to
068be61
Compare
|
@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…ytorch#2955) Summary: The generator part of HiFiGAN model is a vocoder which converts mel spectrogram to waveform. It makes more sense to name it as vocoder for better understanding. Pull Request resolved: pytorch#2955 Reviewed By: carolineechen Differential Revision: D42348864 Pulled By: nateanl fbshipit-source-id: 20e1e07c6e2e132ba7be65ef99cbd187ef5d045d
nateanl
force-pushed
the
rename_hifigan
branch
from
e2c75a4
to
e973c2a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42348864 |
|
Hey @nateanl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator part of HiFiGAN model is a vocoder which converts mel spectrogram to waveform. It makes more sense to name it as vocoder for better understanding.