Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend is not deterministic in test #715

Closed
mthrok opened this issue Jun 11, 2020 · 1 comment
Closed

Backend is not deterministic in test #715

mthrok opened this issue Jun 11, 2020 · 1 comment

Comments

@mthrok
Copy link
Collaborator

mthrok commented Jun 11, 2020

When I work on backend management logics, some tests that depends on specific I/O starts to fail.

In the following case, Kaldi compatibility test starts to fail when backend is somehow changed to soundfile.
(This also suggests that load_wav produces different results between sox backend and soundfile backend.)

https://app.circleci.com/pipelines/github/pytorch/audio/2114/workflows/e00835a3-c9bd-46d0-84ab-d9a705c4c968/jobs/54309/steps

To fix this, we need to make our test suite backend aware, and introduce a notation of default backend to be used unless separately specified. then have each test to specify/initialize the backend to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant