Fix tensor shapes in unit tests #1620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: pytorch#1618 `BotorchTestCase.assertAllClose` is a thin wrapper around `torch.testing.assert_close`, designed to replace usages of `self.assertTrue(torch.allclose(...))`. Using has several advantages over `torch.allclose`: * Checks that shapes are equal, not just values * More configurability and better defaults, such as higher tolerances for single precision, if we choose to use them in the future. for the time being, I've set up this wrapper so that numerical checks remain exactly the same as they used to be. * More informative test output, showing what was put in and why the test failed: Old test output: ```AssertionError: False is not true``` New test output: ``` 1) AssertionError: Scalars are not close! Absolute difference: 1.0000034868717194 (up to 0.0001 allowed) Relative difference: 0.8348668001940709 (up to 1e-05 allowed) ``` Differential Revision: https://internalfb.com/D42402142 fbshipit-source-id: c729ed6ea7c0e16487e3bc7e174b6e4c675cc19a
Summary: As a result of switching from `self.AssertTrue(torch.allclose(...))` to `self.AssertAllClose` in unit tests, we will now also have checks that tensors compared are the same shape and not just numerically equal. Some of our current tests were failing; this fixes that by changing the shapes of the compared tensors. Differential Revision: D42402387 fbshipit-source-id: 15c42cb6d4c07b857092ece5d29b3a7fbd125661
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42402387 |
Codecov Report
@@ Coverage Diff @@
## main #1620 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 154 154
Lines 13774 13776 +2
=========================================
+ Hits 13774 13776 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been merged in a0d6812. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As a result of switching from
self.AssertTrue(torch.allclose(...))toself.AssertAllClosein unit tests, we will now also have checks that tensors compared are the same shape and not just numerically equal. Some of our current tests were failing; this fixes that by changing the shapes of the compared tensors.Differential Revision: D42402387