-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Add maximize
flag to PosteriorMean
acquisition function
#875
Comments
Hi @lukasfro. With the existing API, you can use
to minimize the posterior mean. This will internally negate the posterior, so any value you get out of this will also be negated. You may have noticed that everything is maximized by default in BoTorch. If you need to minimize a function, it is typically easiest to just negate your function evaluations and maximize that. In the past, I worked with BoTorch in a minimization setting without negating the function evaluations and things get messy pretty quickly. |
Hi @saitcakmak, thanks for the clarification. It looks like |
I think it would be fine to add a |
Sounds good to me. Will create the PR next week! |
I don't think |
For |
Unlike other acquisition functions, the
PosteriorMean
does not have amaximize
flag, hence it is not currently not possible to find the minimum of the posterior mean function viaoptimize_acqf
. This should not be too much effort to implement. Happy to create a PR when the feature is desired.The text was updated successfully, but these errors were encountered: