Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string input support? #3992

Closed
sou1x0 opened this issue Jun 15, 2024 · 6 comments
Closed

string input support? #3992

sou1x0 opened this issue Jun 15, 2024 · 6 comments
Assignees
Labels
feature A request for a proper, new feature. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@sou1x0
Copy link

sou1x0 commented Jun 15, 2024

similar to : https://github.com/tensorflow/tensorflow/issues/21213

and how tflite does: tensorflow/tensorflow#21213

could executorch do better on string inputs?

@guangy10
Copy link
Contributor

To make it supported in ExecuTorch I think it needs to be supported in the upstream PyTorch first. I'm not sure if we have a plan to support this feature request. @iseeyuan may know.

@guangy10 guangy10 added feature A request for a proper, new feature. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jun 17, 2024
@cbilgin
Copy link

cbilgin commented Jun 24, 2024

@dbort since Martin is out, any ideas on this one?

@dbort
Copy link
Contributor

dbort commented Jun 25, 2024

Asking about this internally. Like Martin said, EValue doesn't support String, so I don't expect we'd have first-class support.

The alternative is to provide some kind of wrapper to turn the string into a Tensor, but that will result in either a fully-dynamic-shaped input or an upper-bounded and padded input.

@dbort
Copy link
Contributor

dbort commented Jun 25, 2024

@soulx0 do you have a specific use case for this? There are a bunch of trade-offs, so it would help us understand the possible solutions.

@JacobSzwejbka
Copy link
Contributor

String processing is not supported by export nor do I think its planned cc @angelayi

@dbort
Copy link
Contributor

dbort commented Jul 4, 2024

Closing because we have no plans do to this in the near future. The first step would probably require changes on the pytorch/pytorch export side.

@dbort dbort closed this as completed Jul 4, 2024
@dbort dbort closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A request for a proper, new feature. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

5 participants