Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify executorch_runner app to handle all types of ptes #666

Closed
digantdesai opened this issue Oct 6, 2023 · 1 comment
Closed

Unify executorch_runner app to handle all types of ptes #666

digantdesai opened this issue Oct 6, 2023 · 1 comment
Assignees

Comments

@digantdesai
Copy link
Contributor

          sure we can clean it up in the next PR

Originally posted by @digantdesai in #659 (comment)

@digantdesai
Copy link
Contributor Author

Couple of more issues which we deferred in #659, making a list here so we don't forget,

  • Some tabs literals in following,
    • fbcode/executorch/backends/arm/cmake/build.sh:19
    • fbcode/executorch/examples/arm/run.sh:50
    • fbcode/executorch/examples/arm/setup.sh:47
  • remove build.sh and toolchain.sh - use setup.sh and run.sh
  • Align example script with xnnpack setup - removing minimal.py

@robell - let me know if you want to split these and I can also help with these things, so we can close this on Mon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants