Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locations of subword-nmt scripts change #1218

Closed
kevin1kevin1k opened this issue Oct 4, 2019 · 2 comments
Closed

Locations of subword-nmt scripts change #1218

kevin1kevin1k opened this issue Oct 4, 2019 · 2 comments

Comments

@kevin1kevin1k
Copy link

The package subword-nmt is used/mentioned in the following:

Some scripts under subword-nmt have changed locations (though symbolic links are temporarily present in the original location), so the above files should also change accordingly.
(Currently only some DeprecationWarning show up, but errors will probably occur in the future.)
@kevin1kevin1k kevin1kevin1k mentioned this issue Oct 4, 2019
Closed
@kalyangvs
Copy link
Contributor

Please Submit a Pull request pointing to the new files in subword-nmt.
@myleott why Sentencepiece is not being used for normal translation. Is it to help replicate the results in paper. Maybe add an extra arg to prepare scripts via sentencepiece?

@kevin1kevin1k
Copy link
Author

@gvskalyan I've already created a PR #1219 earlier. Thanks!

facebook-github-bot pushed a commit that referenced this issue Nov 7, 2019
@facebook-github-bot
Fix changes of file locations of subword-nmt (#1219)
13d9e2b 
Summary:
Solves #1218.
Pull Request resolved: #1219

Differential Revision: D18339541

Pulled By: myleott

fbshipit-source-id: 6d5bd7b60fa7fd30c038fdad54591343a01f228b
@myleott myleott closed this as completed Dec 16, 2019
facebook-github-bot pushed a commit that referenced this issue Jul 16, 2020
@myleott @facebook-github-bot
Consolidate distributed init code into distributed_utils.call_main (#…
77df83a 
…1218)

Summary:
We use `distributed_utils.call_main` in most of the other CLI tools (e.g., generate.py, eval_lm.py), but not train.py.

The only place where they're different is that train.py supports TPUs and the `after_distributed_init_fn` hook. We can add that support to `distributed_utils.call_main` and merge them.

Pull Request resolved: fairinternal/fairseq-py#1218

Reviewed By: jhcross

Differential Revision: D22556771

Pulled By: myleott

fbshipit-source-id: 4f7110155f5f5d96905ef0bd17a4aa243ec8c443
moussaKam pushed a commit to moussaKam/language-adaptive-pretraining that referenced this issue Sep 29, 2020
@facebook-github-bot
Fix changes of file locations of subword-nmt (facebookresearch#1219)
9ced446 
Summary:
Solves facebookresearch#1218.
Pull Request resolved: facebookresearch#1219

Differential Revision: D18339541

Pulled By: myleott

fbshipit-source-id: 6d5bd7b60fa7fd30c038fdad54591343a01f228b
yzpang pushed a commit to yzpang/gold-off-policy-text-gen-iclr21 that referenced this issue Feb 19, 2021
@yzpang
Fix changes of file locations of subword-nmt (#1219)
10b11d0 
Summary:
Solves facebookresearch/fairseq#1218.
Pull Request resolved: facebookresearch/fairseq#1219

Differential Revision: D18339541

Pulled By: myleott

fbshipit-source-id: 6d5bd7b60fa7fd30c038fdad54591343a01f228b
sshleifer pushed a commit that referenced this issue Apr 7, 2021
@myleott @facebook-github-bot
Consolidate distributed init code into distributed_utils.call_main (#…
980b9ad 
…1218)

Summary:
We use `distributed_utils.call_main` in most of the other CLI tools (e.g., generate.py, eval_lm.py), but not train.py.

The only place where they're different is that train.py supports TPUs and the `after_distributed_init_fn` hook. We can add that support to `distributed_utils.call_main` and merge them.

Pull Request resolved: fairinternal/fairseq-py#1218

Reviewed By: jhcross

Differential Revision: D22556771

Pulled By: myleott

fbshipit-source-id: 4f7110155f5f5d96905ef0bd17a4aa243ec8c443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@myleott @kevin1kevin1k @kalyangvs