Add more details in error message when sentence length > max tokens #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acebookresearch#672) Summary: Pull Request resolved: facebookresearch#672 title Reviewed By: jmp84, pipibjc Differential Revision: D15094977 fbshipit-source-id: 6d94c72bf359a99689338882548742e728ff3735
liezl200
force-pushed
the
export-D15094977
branch
from
5970775
to
d413e99
Compare
|
This pull request has been merged in 89a6961. |
louismartin
pushed a commit
to louismartin/fairseq
that referenced
this pull request
Mar 24, 2020
Summary: Pull Request resolved: pytorch/translate#672 1. Fix typos at export side & small code refactor 2. In validate_export, prepend BOS symbol before translation and remove afterwards. So the result of script matches Decoder strictly. Reviewed By: kahne Differential Revision: D18846014 fbshipit-source-id: 7abd6f7547c2f1af343ad1090e131d34ed52b4d1
yfyeung
pushed a commit
to yfyeung/fairseq
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: title
Reviewed By: jmp84
Differential Revision: D15094977