Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vmap tests use dtype any_one #1092

Closed
samdow opened this issue Dec 27, 2022 · 1 comment
Closed

Make vmap tests use dtype any_one #1092

samdow opened this issue Dec 27, 2022 · 1 comment
Labels
actionable It is clear what should be done for this issue

Comments

@samdow
Copy link
Contributor

samdow commented Dec 27, 2022

In #1069, @kshitij12345 smartly pointed out that it's disturbing that these batch rules aren't caught by test_op_has_batch_rule. From looking at it, the bitwise ops in particular aren't being tested because the only allowed_dtype is torch.float

Steps

  1. First, please update both test_vmap and test_op_has_batch_rule to have their allowed_dtypes (in the @ops decorator) be OpDTypes.any_one instead of torch.float32
  2. We expect this to lead to new failures. Please update the corresponding xfail list for the test.
    i. In the case of test_op_has_batch_rule, if the failure looks to occur on an in-place function, please try first to only add it the inplace_failures list. If this does not work, you can xfail it
@samdow samdow added the actionable It is clear what should be done for this issue label Dec 27, 2022
@kshitij12345
Copy link
Collaborator

Fixed in pytorch/pytorch#91355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable It is clear what should be done for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants