New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyTensorArgs doesn't have to be owning #41

Closed

ezyang opened this issue May 21, 2021 · 1 comment

Contributor

ezyang commented May 21, 2021

https://github.com/zou3519/functorch/blob/68df44f7cdb72864d5e43674357bca7a57b81220/functorch/csrc/PythonKey.cpp#L80

pyArgs is guaranteed to keep it live, so this can be a vector of handles rather than objects.

Contributor

Chillee commented Sep 6, 2021

Fixed in core

Chillee closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment