You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
using DeviceManagerMapTy = std::map<DeviceIDTy, std::shared_ptr<DeviceManager>>;
I think the blocker here is that HostManager::clearHost() won't block on in flight requests #2297 so the ownership of DeviceManager isn't as strong as it should be. HostManager can be deleted but the underlying devices can still be left around running in-flight requests which is why they need to be shared pointers now. Once that is addressed, the ownership model should be improved and these can be safely made unique_ptrs.
The text was updated successfully, but these errors were encountered:
DeviceManager
s are stored as shared_ptrs but they should be unique_ptrs because they are really owned byHostManager
.glow/include/glow/Runtime/RuntimeTypes.h
Line 35 in b975212
I think the blocker here is that
HostManager::clearHost()
won't block on in flight requests #2297 so the ownership ofDeviceManager
isn't as strong as it should be.HostManager
can be deleted but the underlying devices can still be left around running in-flight requests which is why they need to be shared pointers now. Once that is addressed, the ownership model should be improved and these can be safely madeunique_ptrs
.The text was updated successfully, but these errors were encountered: