Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecutionEngine.runBatch fails with weird error when it's run on a network compiled with Infer mode #250

Closed
rdzhabarov opened this issue Jan 11, 2018 · 2 comments
Labels

Comments

@rdzhabarov
Copy link
Contributor

rdzhabarov commented Jan 11, 2018

Reproduce: Compile with asan and execute runBatch on network compiled with Infer mode.

We should check how NN was originally compiled and throw an appropriate exception in case of incompatibility.

Upd: Make an assert instead of throwing an exception.

@rdzhabarov rdzhabarov added the bug label Jan 11, 2018
@nadavrot
Copy link
Contributor

@rdzhabarov We compile the code without support for exceptions. We should crash with an assertion if we run into a bug in the program.

@nadavrot
Copy link
Contributor

nadavrot commented Sep 8, 2018

@rdzhabarov I spent some time refactoring runBatch, and it now has a different implementation. I did not run into problems. It been 9mo since this issue has been filed. I'll close it unless there is anything actionable that you suggest we do.

@nadavrot nadavrot closed this as completed Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants