You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Keep in mind that whatever decision we have should either be friendly to what configen supports now or be added there.
I don't think we can do torch_config.optim.AdamConf right now.
Alright, until someone can raise an issue, we are going to stick with: hydra_configs.<module_path>. If others create their own configen configs such as: https://github.com/romesco/hydra-lightning for example, the idea is to ensure the package is set up as a compatible native namespace package. This means the module dir name is config and there is no __init__.py at the top level.
If those conventions are adhered to, many structured configs from different projects can be imported along side each other like in this example:
Quoting @omry:
I agree with this.
Alternatives are
torch_config.optim.AdamConf
. Usingconfig.*
is probably too generic of a module name and I imagine could lead to collisions.The text was updated successfully, but these errors were encountered: