Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI : bug with python 2.7 opengym #424

Closed
vfdev-5 opened this issue Feb 7, 2019 · 2 comments
Closed

Fix CI : bug with python 2.7 opengym #424

vfdev-5 opened this issue Feb 7, 2019 · 2 comments
Labels
0.2.0 bug help wanted
Projects
0.2.0

Comments

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 7, 2019

Currently, CI is broken, smoke tests of RL examples fail using opengym. Need to investigate.
@vfdev-5 vfdev-5 added this to To do in 0.2.0 via automation Feb 7, 2019
@zasdfgbnm zasdfgbnm mentioned this issue Feb 9, 2019
Merged
3 tasks
@anmolsjoshi
Copy link
Contributor

anmolsjoshi commented Feb 9, 2019 •
edited

@vfdev-5 looked into this, this is an issue with the super call in discrete.py

This was recently fixed on the master branch using this PR. I built gym from the master branch and the tests in travis.yml passed.

One option is to ignore the test and wait till a new release is cut, or we can just build from master. Thoughts?

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Feb 9, 2019

Thanks @anmolsjoshi, maybe we can set now the version of opengym to the previous stable one and once the bug is fixed, remove the version fix.

@anmolsjoshi anmolsjoshi mentioned this issue Feb 9, 2019
Merged
3 tasks
0.2.0 automation moved this from To do to Done Feb 9, 2019
This was referenced Feb 9, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.2.0 bug help wanted
Projects
No open projects
0.2.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vfdev-5 @anmolsjoshi