Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add W&B logger #865

Closed
vfdev-5 opened this issue Mar 30, 2020 · 7 comments 路 Fixed by #926
Closed

Add W&B logger #865

vfdev-5 opened this issue Mar 30, 2020 · 7 comments 路 Fixed by #926

Comments

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 30, 2020

馃殌 Feature

Add logger to W&B similarly to MLflow, Neptune...

@fdlm
Copy link
Contributor

fdlm commented Apr 3, 2020

I might be able to help with this. What should the logger be able to log, at minimum, for the first version?

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Apr 3, 2020

@fdlm thanks ! Let's start with main wrapper and OutputHandler to log scalars.

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Apr 6, 2020

@fdlm feel free to ask if you need help to implement it.

@kai-tub
Copy link
Contributor

kai-tub commented Apr 9, 2020

I also thought about contributing to this feature, but due to time constraints and still having open issues (sry 馃槄 ) I decided not to, but I would like to put in my 2ct:

  • Due to the high flexibility of wandb I would go for an implementation style like in ml-flow-logger
  • A possible issue would be the different usages of the current step in wandb. Some people just log every step independently and log the epochs extra (flexible) and others log them with the epochs to combine the different logs to a single upload per epoch and to get nice default diagrams

What are your opinions @fdlm ? :)

@fdlm
Copy link
Contributor

fdlm commented Apr 10, 2020

I agree, and I think the general logging framework of ignite allows for a very flexible solution. Basically, you can attach output handlers to engines at the desired Event, so you get to decide if you log after each step, or after each epoch. Additionally, you can decide which "step" the logs should be attached to by providing the corresponding global_step_transform function.

So I think it's easy to obtain the flexibility you suggest.

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Apr 15, 2020

@fdlm any updates on the PR ?

@fdlm
Copy link
Contributor

fdlm commented Apr 15, 2020

Finalizing the tests, should have a PR ready later today or tomorrow.

@fdlm fdlm mentioned this issue Apr 16, 2020
3 tasks
@vfdev-5 vfdev-5 moved this from To do to In progress in 0.4.0 Apr 18, 2020
0.4.0 automation moved this from In progress to Done Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.4.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants