Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show scopes for operations #175

Closed
saar-eliad opened this issue Apr 19, 2021 · 3 comments
Closed

Show scopes for operations #175

saar-eliad opened this issue Apr 19, 2021 · 3 comments
Labels
enhancement New feature or request plugin PyTorch Profiler TensorBoard Plugin related

Comments

@saar-eliad
Copy link

Hi,
A key feature we are looking but is currently missing is showing scopes for operations (like the tensorflow profiler).

Example:

empty_

vs.

SequentialModel/layers[2]/Attention/empty_

And we want the 2nd option.
(with the 2nd option, getting combined statistics for all occurrences of empty_ could be done by grouping)

According to the Pytorch API, using with_stack=True would only record file and line numbers.
Unfortunately, file and line numbers is still confusing since we can have both

  • SequentialModel/layers[2]/Attention/empty_
  • SequentialModel/layers[3]/SomeModelWithAttention/Attention/empty_

which would point to the same place in code.

@nbcsm nbcsm added the enhancement New feature or request label Apr 19, 2021
@nbcsm
Copy link
Contributor

nbcsm commented Apr 19, 2021

Thanks for the feedback.
We will take this into consideration for future releases.
@ilia-cher for awareness.

@nbcsm nbcsm added the plugin PyTorch Profiler TensorBoard Plugin related label Apr 22, 2021
@gaoteng-git
Copy link
Contributor

@saar-eliad Our latest tensorboard plugin support grouping-by operators with same call-stacks as key.
image

@ilia-cher
Copy link

@bitfort Victor, I think that work on surfacing layer names could help here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin PyTorch Profiler TensorBoard Plugin related
Projects
None yet
Development

No branches or pull requests

5 participants