Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConcreteInterpreterSessionImpl::pickle is called for Dicts containing Tensors #3

Open
d4l3k opened this issue Apr 13, 2022 · 0 comments
Open

ConcreteInterpreterSessionImpl::pickle is called for Dicts containing Tensors #3

d4l3k opened this issue Apr 13, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@d4l3k
Copy link
Contributor

d4l3k commented Apr 13, 2022 •
edited
Loading

ConcreteInterpreterSessionImpl::pickle seems to be quite expensive in our stack: https://fburl.com/strobelight/bfwdctiy maybe there is some opportunities for optimizations

We call pickle for Dicts containing torch tensors. This is a fairly expensive operation so we should have some way of handling it in a more performant way.

2022-04-13-155055_2111x1137_scrot
2022-04-13-154924_585x489_scrot
@d4l3k d4l3k added the enhancement New feature or request label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@d4l3k