Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISABLED test_adadelta (optim.test_optim.TestOptim) #102941

Closed
pytorch-bot bot opened this issue Jun 5, 2023 · 16 comments
Closed

DISABLED test_adadelta (optim.test_optim.TestOptim) #102941

pytorch-bot bot opened this issue Jun 5, 2023 · 16 comments
Assignees
Labels
module: flaky-tests Problem is a flaky test in CI module: optimizer Related to torch.optim skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 5, 2023

Platforms: dynamo

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Over the past 3 hours, it has been determined flaky in 2 workflow(s) with 4 failures and 2 successes.

Debugging instructions (after clicking on the recent samples link):
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:

  1. Click on the workflow logs linked above
  2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
  3. Grep for test_adadelta
  4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.

Test file path: optim/test_optim.py or optim/test_optim.py

cc @vincentqb @jbschlosser @albanD @janeyx99

@pytorch-bot pytorch-bot bot added module: flaky-tests Problem is a flaky test in CI module: optimizer Related to torch.optim skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jun 5, 2023
@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 5, 2023

Hello there! From the DISABLED prefix in this issue title, it looks like you are attempting to disable a test in PyTorch CI. The information I have parsed is below:
  • Test name: test_adadelta (optim.test_optim.TestOptim)
  • Platforms for which to skip the test: dynamo
  • Disabled by pytorch-bot[bot]

Within ~15 minutes, test_adadelta (optim.test_optim.TestOptim) will be disabled in PyTorch CI for these platforms: dynamo. Please verify that your test name looks correct, e.g., test_cuda_assert_async (__main__.TestCuda).

To modify the platforms list, please include a line in the issue body, like below. The default action will disable the test for all platforms if no platforms list is specified.

Platforms: case-insensitive, list, of, platforms

We currently support the following platforms: asan, dynamo, inductor, linux, mac, macos, rocm, win, windows.

@janeyx99
Copy link
Contributor

janeyx99 commented Jun 5, 2023

@mlazos does this have to do with the grouping change?

@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 5, 2023

Another case of trunk flakiness has been found here.
Please verify the issue was opened after this instance, that the platforms list includes all of
[dynamo], or disable bot might not be working as expected.

@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 5, 2023

Another case of trunk flakiness has been found here.
Please verify the issue was opened after this instance, that the platforms list includes all of
[dynamo], or disable bot might not be working as expected.

@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 5, 2023

Another case of trunk flakiness has been found here.
Please verify the issue was opened after this instance, that the platforms list includes all of
[dynamo], or disable bot might not be working as expected.

@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 5, 2023

Another case of trunk flakiness has been found here.
Please verify the issue was opened after this instance, that the platforms list includes all of
[dynamo], or disable bot might not be working as expected.

@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 5, 2023

Another case of trunk flakiness has been found here.
Please verify the issue was opened after this instance, that the platforms list includes all of
[dynamo], or disable bot might not be working as expected.

@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 5, 2023

Another case of trunk flakiness has been found here.
Please verify the issue was opened after this instance, that the platforms list includes all of
[dynamo], or disable bot might not be working as expected.

@mlazos mlazos self-assigned this Jun 5, 2023
@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 5, 2023

Another case of trunk flakiness has been found here.
Please verify the issue was opened after this instance, that the platforms list includes all of
[dynamo], or disable bot might not be working as expected.

@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 6, 2023

Another case of trunk flakiness has been found here.
Please verify the issue was opened after this instance, that the platforms list includes all of
[dynamo], or disable bot might not be working as expected.

@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 6, 2023

Another case of trunk flakiness has been found here.
Please verify the issue was opened after this instance, that the platforms list includes all of
[dynamo], or disable bot might not be working as expected.

@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 6, 2023

Another case of trunk flakiness has been found here.
Please verify the issue was opened after this instance, that the platforms list includes all of
[dynamo], or disable bot might not be working as expected.

@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 6, 2023

Another case of trunk flakiness has been found here.
Please verify the issue was opened after this instance, that the platforms list includes all of
[dynamo], or disable bot might not be working as expected.

@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 6, 2023

Another case of trunk flakiness has been found here.
Please verify the issue was opened after this instance, that the platforms list includes all of
[dynamo], or disable bot might not be working as expected.

@pytorch-bot
Copy link
Author

pytorch-bot bot commented Jun 6, 2023

Another case of trunk flakiness has been found here.
Please verify the issue was opened after this instance, that the platforms list includes all of
[dynamo], or disable bot might not be working as expected.

@clee2000 clee2000 changed the title DISABLED test_adadelta (__main__.TestOptim) DISABLED test_adadelta (optim.test_optim.TestOptim) Jun 6, 2023
@janeyx99
Copy link
Contributor

janeyx99 commented Jun 9, 2023

Closing this as #103322 should encompass this skip.

@janeyx99 janeyx99 closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: flaky-tests Problem is a flaky test in CI module: optimizer Related to torch.optim skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants