Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

torchgen/gen_backend_stubs.py compatibility with DispatchStubs #103370

Open
neeldug opened this issue Jun 10, 2023 · 1 comment
Open

torchgen/gen_backend_stubs.py compatibility with DispatchStubs #103370

neeldug opened this issue Jun 10, 2023 · 1 comment
Labels
module: codegen Issues related to the codegen for Aten and Autograd module: dispatch DispatchStub, Type, void pointer table, c10 dispatch module: structured kernels Related to new structured kernels functionality triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@neeldug
Copy link

neeldug commented Jun 10, 2023

馃殌 The feature, motivation and pitch

For our out-of-tree backend, I would like to support many structured kernels similar to how is done in CUDA, i.e. registering DispatchStub per operation, similar to how is done here, for PrivateUse1, the support for registering stubs was added in this PR.

This PR however, does not tackle how to implement structured kernels in the same manner. It would be nice if get_backend_stubs.py could support implementation paths of this form instead.

I'm not certain as to whether torchgen could support the reuse of these kernels with overridden headers, which is how we've implemented a method to redirect CUDA kernel launches from our backend successfully with various unstructured kernels.

Alternatives

No response

Additional context

No response

cc @ezyang @bhosmer @bdhirsh

@mikaylagawarecki mikaylagawarecki added the module: dispatch DispatchStub, Type, void pointer table, c10 dispatch label Jun 13, 2023
@mikaylagawarecki
Copy link
Contributor

cc @bdhirsh

@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 13, 2023
@bdhirsh bdhirsh added module: codegen Issues related to the codegen for Aten and Autograd module: structured kernels Related to new structured kernels functionality labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: codegen Issues related to the codegen for Aten and Autograd module: dispatch DispatchStub, Type, void pointer table, c10 dispatch module: structured kernels Related to new structured kernels functionality triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

3 participants