Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Isolate TorchScript-based code-base from Dynamo-based ONNX exporter for easier deprecation #103965

Closed
1 task done
thiagocrepaldi opened this issue Jun 21, 2023 · 1 comment
Closed
1 task done

[ONNX] Isolate TorchScript-based code-base from Dynamo-based ONNX exporter for easier deprecation #103965

thiagocrepaldi opened this issue Jun 21, 2023 · 1 comment
Assignees
@thiagocrepaldi
Labels
enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: onnx Related to torch.onnx triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@thiagocrepaldi
Copy link
Collaborator

thiagocrepaldi commented Jun 21, 2023 •
edited

馃悰 Describe the bug

Currently, many files and helpers are being shared between both torchscript-based and dynamo-based ONNX exporter.

With future deprecation of TorchScript based exporter and the rise of Dynamo-based exporter in mind, we could start separating both exporter into different folders/files to make deprecation easy.

That should also make the code-base more organized and compact

Versions

pytorch main branch

Tasks
Beta Give feedback
  1. [ONNX] Separate fx _type_utils from torchscript exporter #103942
    Merged ciflow/trunk module: onnx open source release notes: onnx topic: not user facing
@thiagocrepaldi thiagocrepaldi added module: onnx Related to torch.onnx enhancement Not as big of a feature, but technically not a bug. Should be easy to fix labels Jun 21, 2023
@thiagocrepaldi thiagocrepaldi self-assigned this Jun 21, 2023
@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 21, 2023
@thiagocrepaldi
Copy link
Collaborator Author

Closing as the new ONNX IR task will superseed this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thiagocrepaldi thiagocrepaldi

Labels
enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: onnx Related to torch.onnx triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
ONNX
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thiagocrepaldi @drisspg