Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ProcessGroupNCCL::pointToPoint to warn about TORCH_NCCL_AVOID_RECORD_STREAMS #108380

Closed
awgu opened this issue Aug 31, 2023 · 0 comments
Closed

Update ProcessGroupNCCL::pointToPoint to warn about TORCH_NCCL_AVOID_RECORD_STREAMS #108380

awgu opened this issue Aug 31, 2023 · 0 comments
Labels
actionable oncall: distributed Add this issue/PR to distributed oncall triage queue topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@awgu
Copy link
Contributor

awgu commented Aug 31, 2023 •
edited by pytorch-bot bot
Loading

We should change NCCL_AVOID_RECORD_STREAMS to TORCH_NCCL_AVOID_RECORD_STREAMS in the warning since the latter is the correct env var name:

pytorch/torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp

Lines 1849 to 1852 in bae4093

TORCH_WARN_ONCE(
avoidRecordStreams_,
"NCCL_AVOID_RECORD_STREAMS=1 has no effect for point-to-point "
"collectives.");

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @penguinwu
@awgu awgu added oncall: distributed Add this issue/PR to distributed oncall triage queue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module actionable topic: docs topic category labels Aug 31, 2023
@FFFrog FFFrog mentioned this issue Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable oncall: distributed Add this issue/PR to distributed oncall triage queue topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix the issue decribled by #108380 FFFrog/pytorch
1 participant
@awgu