Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please offer packages with local version torch==2.1.0+cpu for macOS #110004

Closed
maxhgerlach opened this issue Sep 25, 2023 · 1 comment
Closed
Labels
module: build Build system issues oncall: releng In support of CI and Release Engineering triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@maxhgerlach
Copy link

maxhgerlach commented Sep 25, 2023

馃殌 The feature, motivation and pitch

https://download.pytorch.org/whl/test/torch/ offers CPU builds of version 2.1.0 RC. For Intel Linux and Windows both packages are available with local version 2.1.0+cpu. For macOS there is only version 2.1.0 without an appended local version.

This currently makes it very hard to add PyTorch as a dependency to a project managed with poetry if compatibility to both Linux and macOS is desired. In poetry it's currently not possible to prefer 2.1.0 over 2.1.0+cpu (python-poetry/poetry#7256) and there's no working way to configure packages from this same source for different systems with different local version numbers.

Alternatives

Users could host the packages themselves (with controlled version numbers), but that is not possible in all situations.

Additional context

Poetry is a very popular solution to manage dependencies of complex Python projects. It would be great if PyTorch worked well with it.

cc @malfet @seemethere

@albanD albanD added module: build Build system issues oncall: releng In support of CI and Release Engineering triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Sep 25, 2023
@malfet
Copy link
Contributor

malfet commented Feb 25, 2024

Closing as implemented, PyTorch should work well with poetry in 2.1 and above. If this is not the case, please do not hesitate to file a separate issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: build Build system issues oncall: releng In support of CI and Release Engineering triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

3 participants