Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISABLED test_foreach_matches_forloop_RAdam_cpu_float64 (__main__.TestOptimRenewedCPU) #125057

Open
pytorch-bot bot opened this issue Apr 26, 2024 · 3 comments
Labels
module: dynamo module: flaky-tests Problem is a flaky test in CI module: optimizer Related to torch.optim oncall: pt2 skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 26, 2024

Platforms: dynamo

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Over the past 3 hours, it has been determined flaky in 3 workflow(s) with 3 failures and 3 successes.

Debugging instructions (after clicking on the recent samples link):
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:

  1. Click on the workflow logs linked above
  2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
  3. Grep for test_foreach_matches_forloop_RAdam_cpu_float64
  4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.
Sample error message
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/test/test_optim.py", line 677, in test_foreach_matches_forloop
    self._test_derived_optimizers(device, dtype, optim_info, "foreach")
  File "/var/lib/jenkins/workspace/test/test_optim.py", line 672, in _test_derived_optimizers
    self._compare_between(input, models, optimizers, assert_eq_kwargs, assert_step_dtype)
  File "/var/lib/jenkins/workspace/test/test_optim.py", line 606, in _compare_between
    optimizer.step()
  File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/optim/optimizer.py", line 438, in wrapper
    out = func(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/optim/optimizer.py", line 87, in _use_grad
    ret = func(self, *args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/optim/radam.py", line 140, in step
    radam(
  File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/optim/radam.py", line 280, in radam
    func(
  File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/optim/radam.py", line 323, in _single_tensor_radam
    assert (param.is_cuda and step_t.is_cuda) or (
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: If capturable=True, params and state_steps must be CUDA or XLA tensors.

To execute this test, run the following from the base repo dir:
    PYTORCH_TEST_WITH_DYNAMO=1 python test/test_optim.py -k test_foreach_matches_forloop_RAdam_cpu_float64

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0

Test file path: test_optim.py

cc @vincentqb @jbschlosser @albanD @janeyx99 @crcrpar @clee2000 @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng

@pytorch-bot pytorch-bot bot added module: flaky-tests Problem is a flaky test in CI module: optimizer Related to torch.optim oncall: pt2 skipped Denotes a (flaky) test currently skipped in CI. labels Apr 26, 2024
Copy link
Author

pytorch-bot bot commented Apr 26, 2024

Hello there! From the DISABLED prefix in this issue title, it looks like you are attempting to disable a test in PyTorch CI. The information I have parsed is below:
  • Test name: test_foreach_matches_forloop_RAdam_cpu_float64 (__main__.TestOptimRenewedCPU)
  • Platforms for which to skip the test: dynamo
  • Disabled by pytorch-bot[bot]

Within ~15 minutes, test_foreach_matches_forloop_RAdam_cpu_float64 (__main__.TestOptimRenewedCPU) will be disabled in PyTorch CI for these platforms: dynamo. Please verify that your test name looks correct, e.g., test_cuda_assert_async (__main__.TestCuda).

To modify the platforms list, please include a line in the issue body, like below. The default action will disable the test for all platforms if no platforms list is specified.

Platforms: case-insensitive, list, of, platforms

We currently support the following platforms: asan, dynamo, inductor, linux, mac, macos, rocm, slow, win, windows.

1 similar comment
Copy link
Author

pytorch-bot bot commented Apr 26, 2024

Hello there! From the DISABLED prefix in this issue title, it looks like you are attempting to disable a test in PyTorch CI. The information I have parsed is below:
  • Test name: test_foreach_matches_forloop_RAdam_cpu_float64 (__main__.TestOptimRenewedCPU)
  • Platforms for which to skip the test: dynamo
  • Disabled by pytorch-bot[bot]

Within ~15 minutes, test_foreach_matches_forloop_RAdam_cpu_float64 (__main__.TestOptimRenewedCPU) will be disabled in PyTorch CI for these platforms: dynamo. Please verify that your test name looks correct, e.g., test_cuda_assert_async (__main__.TestCuda).

To modify the platforms list, please include a line in the issue body, like below. The default action will disable the test for all platforms if no platforms list is specified.

Platforms: case-insensitive, list, of, platforms

We currently support the following platforms: asan, dynamo, inductor, linux, mac, macos, rocm, slow, win, windows.

@jbschlosser jbschlosser added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: dynamo labels Apr 26, 2024
@janeyx99
Copy link
Contributor

cc @mlazos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: dynamo module: flaky-tests Problem is a flaky test in CI module: optimizer Related to torch.optim oncall: pt2 skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

2 participants