Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accuracy regression for cspdarknet53 or flakiness associated with cu121 (and potentially cu124) #127626

Closed
nWEIdia opened this issue May 31, 2024 · 2 comments
Closed

Fix accuracy regression for cspdarknet53 or flakiness associated with cu121 (and potentially cu124) #127626

nWEIdia opened this issue May 31, 2024 · 2 comments
Labels
module: inductor triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@nWEIdia
Copy link
Collaborator

nWEIdia commented May 31, 2024 •
edited by pytorch-bot bot
Loading

Initially I thought this was only happening for cu124 enablement. However, from the dashboard results:

image

The main branch has 20+ hits on 05/31/2024, so this may be a recent regression for cu121.

Use this filter.

cc @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @atalman @malfet @eqy @Fuzzkatt @tinglvv @ptrblck
@nWEIdia nWEIdia mentioned this issue May 31, 2024
Closed
@nWEIdia nWEIdia changed the title Fix accuracy regression for cspdarknet53 or unflaky it since it was not showing up originally Fix accuracy regression for cspdarknet53 or flakiness associated with cu121 (and potentially cu124) May 31, 2024
@nWEIdia
Copy link
Collaborator Author

nWEIdia commented Jun 1, 2024

Link #127367

@cpuhrsch cpuhrsch added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module and removed oncall: pt2 labels Jun 3, 2024
@nWEIdia nWEIdia mentioned this issue Jun 4, 2024
Closed
@nWEIdia
Copy link
Collaborator Author

nWEIdia commented Jun 4, 2024

Fixed by #127949 thanks @shunting314

@nWEIdia nWEIdia closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: inductor triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "[inductor] remove reordering_reindex (#127367)" nWEIdia/pytorch
2 participants
@cpuhrsch @nWEIdia