Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add x/0 gradient behaviour to documentation #128796

Open
heth27 opened this issue Jun 16, 2024 · 1 comment
Open

add x/0 gradient behaviour to documentation #128796

heth27 opened this issue Jun 16, 2024 · 1 comment
Labels
actionable module: autograd Related to torch.autograd, and the autograd engine in general module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@heth27
Copy link

heth27 commented Jun 16, 2024

📚 The doc issue

The behaviour that divison by zero causes nan gradients even when masked (#4132) is not prominent in the documentation. As there are multiple issues of people that ran into this on github it would be nice if it's easier to find.

Suggest a potential alternative/fix

Add this to the documentation, perhaps even to tutorials

cc @svekars @brycebortree @ezyang @albanD @gqchen @pearu @nikitaved @soulitzer @lezcano @Varal7

@mikaylagawarecki mikaylagawarecki added module: autograd Related to torch.autograd, and the autograd engine in general module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jun 17, 2024
@ezyang
Copy link
Contributor

ezyang commented Jun 27, 2024

Send a doc patch and I"ll review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable module: autograd Related to torch.autograd, and the autograd engine in general module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

4 participants