Provide Protobuf library if libtorch was built with included version #14277
Labels
module: build
Build system issues
module: cpp
Related to C++ API
module: protobuf
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Comments
|
the symbols of protobuf built internal to libtorch shouldn't even be exposed to the outside world. afaik those symbols are marked as hidden. Hence, you should be able to safely build and link your C++ app using your protobuf of choice. Are you getting linker errors in your C++ app? |
|
The problem might be elsewhere then. The error I get is a version missmatch when I generate my protoc.hpp file. The missmatch is because of the "google/protobuf/stubs/common.h" file that appears in the included path from TORCH_INCLUDE_DIRS. |
yf225
added
module: protobuf
triaged
|
This is related to #14573. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When building pytorch and libtorch with
python setup.py build, an internal version of protobuf is used. Our C++ app also uses Protobuf but finds an incompatible version with the one used by libtorch. Would it be possible to add to the install a ProtobufConfig.cmake so that we can link against the same protobuf?cc @yf225
The text was updated successfully, but these errors were encountered: