Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibTorch: include cmake files for all distributed headers #15491

Open
Xfel opened this issue Dec 21, 2018 · 3 comments
Open

LibTorch: include cmake files for all distributed headers #15491

Xfel opened this issue Dec 21, 2018 · 3 comments
Labels
module: cpp Related to C++ API triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@Xfel
Copy link

Xfel commented Dec 21, 2018

I'm planning to add libtorch support to a project that already uses pybind11, and I got a few errors because libtorch also bundled pybind11, which is automatically added to the include path.

While it's easy enough to use the bundled pybind11 in our project, there is no clean way to reference this in cmake since the libtorch distribution does not include a cmake config file for pybind11. I would suggest adding it, so that one can properly reference the bundled pybind11 version.

@pytorchbot pytorchbot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Dec 21, 2018
@soumith
Copy link
Member

soumith commented Dec 21, 2018

cc: @goldsborough

@soumith soumith added the module: cpp Related to C++ API label Dec 21, 2018
@teng-li teng-li removed the oncall: distributed Add this issue/PR to distributed oncall triage queue label Jan 2, 2019
@goldsborough
Copy link
Contributor

I guess we need a way to configure the pybind11 install in our CMake. Also cc @anderspapitto @orionr

@famura
Copy link

famura commented Apr 11, 2019

What's the status of this problem?

I have seen that in the latest PyTorch version (1.0.1) a development version of pybind11 is used.

@zhangguanheng66 zhangguanheng66 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: cpp Related to C++ API triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

7 participants